Refactor to generate Cartesian product instead of permutations#2
Merged
Refactor to generate Cartesian product instead of permutations#2
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the permutations algorithm to correctly implement a Cartesian product generator instead. The change addresses a conceptual error where the original code was mislabeled as generating "permutations" when it actually produced Cartesian products.
Key changes:
- Renamed file from
permutations.cpptocartesian_product.cpp - Updated data structures from
std::set<int>tostd::vector<int>to maintain order in tuples - Corrected terminology and documentation to reflect Cartesian product generation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/1_Arrays/permutations.cpp | Removed the incorrectly named permutations implementation |
| src/1_Arrays/cartesian_product.cpp | Added properly named Cartesian product implementation with ordered tuples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.